fix error when colorscale given boolean array (#2193)

* fix error when colorscale given boolean array * add comment
nilearn · Oct 28, 2019 · bd27cf5 · bd27cf5
1 parent 053e5a8
commit bd27cf5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/nilearn/plotting/js_plotting_utils.py b/nilearn/plotting/js_plotting_utils.py
@@ -87,6 +87,8 @@ def colorscale(cmap, values, threshold=None, symmetric_cmap=True,
         vmin = 0
     if vmax is None:
         vmax = abs_values.max()
+    # cast to float to avoid TypeError if vmax is a numpy boolean
+    vmax = float(vmax)
     if symmetric_cmap:
         vmin = - vmax
     if vmin is None:

diff --git a/nilearn/plotting/tests/test_js_plotting_utils.py b/nilearn/plotting/tests/test_js_plotting_utils.py
@@ -62,6 +62,7 @@ def test_colorscale_no_threshold():
     assert colors['cmap'].N == 256
     assert (colors['norm'].vmax, colors['norm'].vmin) == (13, -13)
     assert colors['abs_threshold'] is None
+    colors = js_plotting_utils.colorscale(cmap, values > 0, .5)
 
 
 def test_colorscale_threshold_0():