Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating functional connectivity examples: merge 8.4.1 and 8.4.7 #1986

Closed
illdopejake opened this issue Apr 15, 2019 · 7 comments · Fixed by #2183
Closed

Consolidating functional connectivity examples: merge 8.4.1 and 8.4.7 #1986

illdopejake opened this issue Apr 15, 2019 · 7 comments · Fixed by #2183

Comments

@illdopejake
Copy link
Contributor

Some of the current nilearn examples include some redundancy that creates unnecessary burden for test run-times.

An example of this would be 8.4.1 (Group analysis of resting-state fMRI with ICA: CanICA) and 8.4.7 (Dictionary Learning and ICA for doing group analysis of resting-state fMRI), which contain a good deal of redundancy.

The goal here would be to create a single example that combines the non-redundant elements from both 8.4.1 and 8.4.7., and perhaps modifying the didactic structure such that it might better reflect the goals and thought-process of an end user.

@GaelVaroquaux GaelVaroquaux added this to To do in Sprint Paris 2019 via automation Apr 15, 2019
@GaelVaroquaux GaelVaroquaux moved this from To do to In progress in Sprint Paris 2019 Apr 15, 2019
@illdopejake
Copy link
Contributor Author

illdopejake commented Apr 16, 2019

As recommended by @KamalakerDadi , would also be useful to merge 8.4.5 (Extracting brain signal from spheres) and 8.4.8 (Extract signals on spheres from an atlas and plot a connectome) into one notebook with both spheres and a full atlas.

So for reference:

  • 8.4.1 + 8.4.7
  • 8.4.5 + 8.4.8

@kchawla-pi

@emdupre
Copy link
Member

emdupre commented Oct 14, 2019

This looks like it was closed with #2013.

@KamalakerDadi
Copy link
Contributor

I think #2013 is missing status on whats_new. I was looking for plot_canica_analysis example to work on my PR #1890 and realized lately that it is merged into plot_compare_decomposition. There is no mention of this in whats_new.

@emdupre
Copy link
Member

emdupre commented Oct 16, 2019

Should we open a new PR specifically for that or do you want to handle it in #1890, @KamalakerDadi ?

@KamalakerDadi
Copy link
Contributor

Should we open a new PR specifically for that or do you want to handle it in #1890, @KamalakerDadi ?

I think you followed it better than me.

@emdupre
Copy link
Member

emdupre commented Oct 16, 2019

Opened #2183 , if you'd like to review @KamalakerDadi ! 😸

@KamalakerDadi
Copy link
Contributor

Opened #2183 , if you'd like to review @KamalakerDadi !

Thanks!

Sprint Paris 2019 automation moved this from In progress to Done Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants