Nilearn sprint example consolidation spheres #2023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkiar
reviewed
Apr 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #2023 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 137 137
Lines 17877 17877
=======================================
Hits 16976 16976
Misses 901 901Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2023 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 137 137
Lines 17877 17877
=======================================
Hits 16976 16976
Misses 901 901Continue to review full report at Codecov.
|
Co-Authored-By: illdopejake <jacobwvogel@gmail.com>
Co-Authored-By: illdopejake <jacobwvogel@gmail.com>
Co-Authored-By: illdopejake <jacobwvogel@gmail.com>
|
I did a pass and that's all I found. Hopefully this builds cleanly and that it's ready for merge! |
Co-Authored-By: illdopejake <jacobwvogel@gmail.com>
|
merging to PR #1986 to reduce CircleCI bandwidth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At @KamalakerDadi 's request, I merged examples 8.4.5 + 8.4.8 (see issue #1986 ). This mostly involved stacking them and removing some redundancies.
I also noticed that 5 subjects were downloaded, but only one was used. So I changed n_subjects=1.
Finally, I fixed a few links pointing to notebook 8.4.5 (none I could find pointed to 8.4.8).