Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version warnings #2214

Merged
merged 6 commits into from Nov 23, 2019
Merged

Conversation

kchawla-pi
Copy link
Collaborator

Fixes #2213

Remove warnings for Python2, 3.4 .
Add warning to for Python 3.5

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #2214 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2214     +/-   ##
=========================================
- Coverage   92.64%   92.55%   -0.1%     
=========================================
  Files         150      150             
  Lines       19004    18984     -20     
  Branches     2309     2307      -2     
=========================================
- Hits        17606    17570     -36     
- Misses        891      907     +16     
  Partials      507      507
Impacted Files Coverage Δ
nilearn/__init__.py 79.31% <100%> (+7.88%) ⬆️
nilearn/tests/test_init.py 100% <100%> (+16.66%) ⬆️
nilearn/reporting/rm_file.py 26.66% <0%> (-53.34%) ⬇️
nilearn/_utils/testing.py 78.76% <0%> (-4.8%) ⬇️
nilearn/plotting/__init__.py 95.65% <0%> (-4.35%) ⬇️
nilearn/plotting/tests/test_js_plotting_utils.py 97.6% <0%> (-1.6%) ⬇️
nilearn/datasets/tests/test_neurovault.py 95.84% <0%> (-0.98%) ⬇️
nilearn/image/image.py 95.63% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2432b97...4dd96ca. Read the comment docs.

@bthirion
Copy link
Member

LGTM.
Maybe an entry in whatsnew...

* 'master' of github.com:nilearn/nilearn:
  Add testing for Nilearn setup & install & Fix the broken dependency installation (nilearn#2201)
  Fix uniform ball cloud test for sklearn >= 0.22 (nilearn#2175)
  MAINT: sklearn Deprecations (nilearn#2219)
  DOC: title in bold
  [DOC] Add note about decreasing memory usage (nilearn#2223)
@kchawla-pi kchawla-pi merged commit ffb300b into nilearn:master Nov 23, 2019
@kchawla-pi kchawla-pi deleted the py35-dep branch November 23, 2019 10:08
kchawla-pi added a commit to effigies/nilearn that referenced this pull request Nov 24, 2019
…ix_package_finder

* 'master' of https://github.com/nilearn/nilearn:
  CI: Test pre-release versions of dependencies (nilearn#2224)
  Fix:  nilearn.image.smooth_img fails if fwhm is an ndarray (nilearn#2107)
  Update Python version warnings for Py35 deprecation (nilearn#2214)
  Fixing failure in minimum build of TravisCI (nilearn#2227)
  Updated missing whats_new entry
kchawla-pi added a commit to darya-chyzhyk/nilearn that referenced this pull request Nov 24, 2019
…s-craddock

* 'master' of https://github.com/nilearn/nilearn: (620 commits)
  CI: Test pre-release versions of dependencies (nilearn#2224)
  Fix:  nilearn.image.smooth_img fails if fwhm is an ndarray (nilearn#2107)
  Update Python version warnings for Py35 deprecation (nilearn#2214)
  Fixing failure in minimum build of TravisCI (nilearn#2227)
  Updated missing whats_new entry
  Add testing for Nilearn setup & install & Fix the broken dependency installation (nilearn#2201)
  Fix uniform ball cloud test for sklearn >= 0.22 (nilearn#2175)
  MAINT: sklearn Deprecations (nilearn#2219)
  DOC: title in bold
  [DOC] Add note about decreasing memory usage (nilearn#2223)
  Rel 060b0 (nilearn#2208)
  Nilearn 0.6.0b0 release (nilearn#2206)
  Fixed the redundant & missing test case in merged PR nilearn#2035 (nilearn#2205)
  Modify fetch_development_fmri to fetch adults or children (nilearn#2035)
  Verbose doc building to ease tracking of progress & diagnose stalls (nilearn#2203)
  New conda env is created once conda path has been activated
  Conda environment is created for full-builds
  Refactor CircleCI config for reduced redundancy (nilearn#2204)
  Installation should fail on Python < 3.5 (nilearn#2198)
  [MRG] Add get data function (nilearn#2172)
  ...

# Conflicts:
#	nilearn/datasets/atlas.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.5 deprecation FutureWarning in Nilearn 0.6.0
2 participants