-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanations for 1st and 2nd level for glm #2599
Comments
@NicolasGensollen Thank you for opening the issue! It seems there are some information in those pages already. With that, is this issue still open as I would love to contribute! Thank you!!! |
You're welcome ! Please review carefully the existing doc and identify missing stuff. |
From @NicolasGensollen original message I am not sure exactly what information is actually missing. I do find the summaries for those pages good enough. But then again I have been dealing fMRI GLMs for a while now, so I think I may not even realize what implicit information may be missing and that I am filling in. So please, have a look and don't hesitate to point out what is missing in your opinion. Random thoughts... Maybe the issue was referring to what the main classes for first and second level actually do ?
Or maybe we should "explain" things in terms of:
|
@Remi-Gau Thank you for pointing out that it seems complete already! I could definitely fill in the missing pieces in terms of implicit information, as I am not an expert in fMRI GLM. With that, I think both random thoughts could be taken care of, but I am struggling to understand what you meant by 'what the main classes for first and second level actually do'. Is it expanding more on the class definition given as 'Implement the General Linear Model for single run fMRI data.' for the first level? Or are you talking about expanding the function definition more, which might not be clear enough (e.g., fit method)? For the second random thought, where do you think we should address that diversity in meanings? I think the GitHub pages would be a great place to update, but I'm not sure if I'm missing anything. Thank you so much! |
I was more thinking about this one
Maybe adding some explanation in this page of the doc? Corresponding to this file: https://github.com/nilearn/nilearn/blob/main/doc/modules/glm.rst Or in the "index" page of the GLM section of the user guide? Corresponding to this file: https://github.com/nilearn/nilearn/blob/main/doc/glm/index.rst
Woohoo!!! Exciting!!! Though thinking back on my first ever contribution, I can relate to the being nervous part. If things are not clear: don't hesitate to ask. Before you jump in, make sure you have look at the "how to contribute" section of the doc. Especially this part: https://nilearn.github.io/stable/development.html#setting-up-your-environment You could also come to the drop in hours if you need guidance on the content of your contributions or how to go about it. |
After some guidance from @Remi-Gau, I have done a PR on comparing the meaning of different GLM (first, second, and third-level models) for FSL and SPM, with the possible extension of extending to comparing with those of AFNI. Feedbacks are truly appreciated! :D |
Add a few lines somewhere in the doc to explain what are
glm
first
andsecond levels
which might not be obvious for researchers from other fields.Note: We could also put a link to these explanations in the html reports.
The text was updated successfully, but these errors were encountered: