Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All CI failing because flake8 --diff option has been removed #3431

Closed
RaphaelMeudec opened this issue Nov 30, 2022 · 3 comments
Closed

All CI failing because flake8 --diff option has been removed #3431

RaphaelMeudec opened this issue Nov 30, 2022 · 3 comments
Labels
Infrastructure This issue describes a problem with the project's infrastructure (CI/CD...).

Comments

@RaphaelMeudec
Copy link
Contributor

RaphaelMeudec commented Nov 30, 2022 •
edited

All CI are currently failing because flake8==6.0.0 (which has been released on Nov 23) does not have the --diff flag anymore.

The reason has been explained in this issue.

A solution which is an adaptation of this comment is replacing the flake8 --diff from build_tools/flake8_diff.sh#L79 with the following command:

git diff --name-only $COMMIT | grep '\.py$' | xargs --delimiter='\n' --no-run-if-empty flake8 --show-source

Opened PR #3432
@RaphaelMeudec RaphaelMeudec added the Bug for bug reports label Nov 30, 2022
@RaphaelMeudec RaphaelMeudec mentioned this issue Nov 30, 2022
Closed
@RaphaelMeudec
Copy link
Contributor Author

Didn't see stalled PR #3420. I'm leaving this issue open as I didn't see a related issue (which lead me to open #3432).

@ymzayek
Copy link
Member

ymzayek commented Nov 30, 2022

Hi @RaphaelMeudec thanks for looking into this. Sure we can keep this issue open and I'll refer to it in that PR with 'closes'.

@ymzayek ymzayek mentioned this issue Nov 30, 2022
Closed
@ymzayek ymzayek added Infrastructure This issue describes a problem with the project's infrastructure (CI/CD...). and removed Bug for bug reports labels Jan 9, 2023
@ymzayek
Copy link
Member

ymzayek commented Feb 6, 2023

Closing this since this check will be removed (or modified rather). See #3484 and #2528

@ymzayek ymzayek closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure This issue describes a problem with the project's infrastructure (CI/CD...).
Projects
None yet
Milestone
No milestone
2 participants
@RaphaelMeudec @ymzayek