Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Surface GLM - Support multiple runs in a GLM #3846

Closed
1 task done
smeisler opened this issue Jul 19, 2023 · 2 comments
Closed
1 task done

[ENH] Surface GLM - Support multiple runs in a GLM #3846

smeisler opened this issue Jul 19, 2023 · 2 comments
Labels
Blocked Enhancement for feature requests GLM Issues/PRs related to the nilearn.glm module. Surface Related to surface data or surface analysis.

Comments

@smeisler
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe your proposed enhancement in detail.

Related to neurostars post: https://neurostars.org/t/glm-on-surface-data-in-nilearn/22632

It would be good if Nilearn could run GLMs on surface data with multiple BOLD runs. Currently, the only way to run a GLM on surface data (nilearn.glm.first_level.run_glm), which only accepts one BOLD run and design matrix per instance.

Benefits to the change

More flexible processing for multi-run surface analyses.

Pseudocode for the new behavior, if applicable

I imagine an easiest, but not most stylish, change would be to have run_glm accept an iterable object for [X] and [Y]. If the length of these iterable objects are 1, then run the function as normal. If not, apply whatever fixed effect models are used for the multi-run GLMs on BOLD data.

Thoughts?

@smeisler smeisler added the Enhancement for feature requests label Jul 19, 2023
@bthirion
Copy link
Member

Thx for opening this. What we need is a SurfaceFirstLevelModel object that can has an API similar to the FirstLevelModel. We'll do that as soon as we have a decent SurfaceMasker.

@Remi-Gau Remi-Gau added GLM Issues/PRs related to the nilearn.glm module. Surface Related to surface data or surface analysis. labels Dec 10, 2023
@Remi-Gau Remi-Gau closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Enhancement for feature requests GLM Issues/PRs related to the nilearn.glm module. Surface Related to surface data or surface analysis.
Projects
None yet
Development

No branches or pull requests

3 participants