New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Allow MultiNiftiMasker
to use generate_report
method
#4001
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4001 +/- ##
==========================================
+ Coverage 91.73% 91.75% +0.02%
==========================================
Files 145 145
Lines 16230 16222 -8
Branches 3367 3370 +3
==========================================
- Hits 14888 14884 -4
+ Misses 797 795 -2
+ Partials 545 543 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Just beware the failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a bit more coverage. Looks good otherwise.
CodeCov still complains about two untested lines. Is it wrong ? |
Made 2 small suggestions that should take care of the coverage by making the |
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
@Remi-Gau yes that works. Not really sure about the codecov report but anyways it should be good now. Well let's see |
This one should be good to go. Any last comments? |
go for it |
generate_report
method of multi-subject maskers #3960Changes proposed in this pull request:
generate_report
for one subject for now (mimicking multi labels and maps masker behavior)