Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow MultiNiftiMasker to use generate_report method #4001

Merged
merged 12 commits into from Oct 5, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Sep 22, 2023

Changes proposed in this pull request:

  • Allow MultiNiftiMasker to use generate_report for one subject for now (mimicking multi labels and maps masker behavior)

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #4001 (0cb4ee6) into main (b3385c5) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4001      +/-   ##
==========================================
+ Coverage   91.73%   91.75%   +0.02%     
==========================================
  Files         145      145              
  Lines       16230    16222       -8     
  Branches     3367     3370       +3     
==========================================
- Hits        14888    14884       -4     
+ Misses        797      795       -2     
+ Partials      545      543       -2     
Flag Coverage Δ
macos-latest_3.10 91.67% <100.00%> (?)
macos-latest_3.11 91.67% <100.00%> (+0.02%) ⬆️
macos-latest_3.12 91.67% <100.00%> (?)
macos-latest_3.8 91.63% <100.00%> (+0.02%) ⬆️
macos-latest_3.9 91.63% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10 91.67% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11 91.67% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.12 91.67% <100.00%> (?)
ubuntu-latest_3.8 91.63% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9 91.63% <100.00%> (+0.02%) ⬆️
windows-latest_3.10 91.61% <100.00%> (+0.02%) ⬆️
windows-latest_3.11 91.61% <100.00%> (+0.02%) ⬆️
windows-latest_3.12 91.61% <100.00%> (?)
windows-latest_3.8 91.57% <100.00%> (+0.02%) ⬆️
windows-latest_3.9 91.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nilearn/maskers/multi_nifti_masker.py 95.00% <100.00%> (+1.81%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Just beware the failure.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a bit more coverage. Looks good otherwise.

@bthirion
Copy link
Member

bthirion commented Oct 4, 2023

CodeCov still complains about two untested lines. Is it wrong ?
The PR LGTM otherwise.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Oct 5, 2023

Made 2 small suggestions that should take care of the coverage by making the else the default. As far as I can tell this should not affect behavior: @ymzayek am I correct?

ymzayek and others added 2 commits October 5, 2023 10:25
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
@ymzayek
Copy link
Member Author

ymzayek commented Oct 5, 2023

@Remi-Gau yes that works. Not really sure about the codecov report but anyways it should be good now. Well let's see

@ymzayek
Copy link
Member Author

ymzayek commented Oct 5, 2023

This one should be good to go. Any last comments?

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Oct 5, 2023

This one should be good to go. Any last comments?

go for it

@ymzayek ymzayek merged commit 3b9e093 into nilearn:main Oct 5, 2023
32 checks passed
@ymzayek ymzayek deleted the multiniftimasker-report branch October 5, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants