Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Specify full form of LSS in beta series tutorial #4141

Merged
merged 6 commits into from Dec 12, 2023

Conversation

TamerGezici
Copy link
Contributor

Makes the text more coherent (as the full form for LSA is written above) and prevents people from scrolling up to remember what LSS stands for.

Makes it more coherent and prevents people from scrolling up to remember what LSS stands for.
Copy link
Contributor

👋 @TamerGezici Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@TamerGezici TamerGezici changed the title Specify full form of LSS in DOC [DOC] Specify full form of LSS in beta series tutorial Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d95dad9) 91.90% compared to head (6664201) 91.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4141      +/-   ##
==========================================
- Coverage   91.90%   91.82%   -0.08%     
==========================================
  Files         145      145              
  Lines       16330    16330              
  Branches     3404     3404              
==========================================
- Hits        15008    14995      -13     
- Misses        778      789      +11     
- Partials      544      546       +2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.68% <ø> (?)
macos-latest_3.8_test_plotting 91.64% <ø> (?)
macos-latest_3.9_test_plotting 91.65% <ø> (ø)
ubuntu-latest_3.10_test_plotting ?
ubuntu-latest_3.11_test_plotting ?
ubuntu-latest_3.12_test_plotting ?
ubuntu-latest_3.12_test_pre ?
ubuntu-latest_3.8_test_min 68.88% <ø> (ø)
ubuntu-latest_3.8_test_plot_min ?
ubuntu-latest_3.8_test_plotting ?
ubuntu-latest_3.9_test_plotting ?
windows-latest_3.10_test_plotting ?
windows-latest_3.11_test_plotting ?
windows-latest_3.12_test_plotting 91.66% <ø> (ø)
windows-latest_3.8_test_plotting ?
windows-latest_3.9_test_plotting ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/changes/latest.rst Outdated Show resolved Hide resolved
examples/07_advanced/plot_beta_series.py Outdated Show resolved Hide resolved
TamerGezici and others added 2 commits December 11, 2023 13:19
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @TamerGezici this one should be good to go once the tests pass

examples/07_advanced/plot_beta_series.py Outdated Show resolved Hide resolved
@ymzayek ymzayek merged commit 1d55006 into nilearn:main Dec 12, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants