[MAINT] Remove unnecessary lines describe in test_clean_psc
#4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es a useless line nilearn#4175. This caused a third line to be unnecessary so I removed it also.
|
👋 @paul-reiners Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
paul-reiners
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4208 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 144 144
Lines 16366 16366
Branches 3426 3426
=======================================
Hits 15073 15073
Misses 754 754
Partials 539 539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remi-Gau
changed the title
Remi-Gau
changed the title
test_clean_psc
Remi-Gau
changed the title
test_clean_psctest_clean_psc
Remi-Gau
reviewed
Jan 11, 2024
ymzayek
reviewed
Jan 11, 2024
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
|
Believe it's ready to go now. Thanks for all your help so far. |
|
thanks @paul-reiners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a third line to be unnecessary so I removed it also.
test_clean_pscincludes a useless line #4175Changes proposed in this pull request: