[DOC] update dataset descriptions #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Remi-Gau
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4215 +/- ##
==========================================
- Coverage 92.10% 92.07% -0.03%
==========================================
Files 144 144
Lines 16368 16385 +17
Branches 3427 3427
==========================================
+ Hits 15075 15086 +11
- Misses 754 760 +6
Partials 539 539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remi-Gau
changed the title
Remi-Gau
commented
Jan 12, 2024
Remi-Gau
commented
Jan 12, 2024
nilearn/datasets/func.py
Outdated
| for f in files | ||
| ] | ||
| return data_dir, sorted(file_list) | ||
| description = get_dataset_descr("language_localizer_demo") | ||
| return data_dir, sorted(file_list), description |
There was a problem hiding this comment.
Break of API: see comment in https://github.com/nilearn/nilearn/pull/4215/files#r1450382982
|
TODOs for other PRs:
|
Remi-Gau
commented
Jan 12, 2024
| @@ -0,0 +1,34 @@ | |||
| localizer first level | |||
There was a problem hiding this comment.
dataset hosted here: https://osf.io/v7hsw/?view_only=
but cannot find a whole lot more info about it
Remi-Gau
force-pushed
the
dataset_descriptions
branch
from
8a394b6
to
57a9c92
Compare
|
Looking at the data from those 2 datasets, I am not sure I can tell the difference between the 2? Events files look kind of similar.
Also the bids_langloc_dataset seems unused in our examples. |
ymzayek
reviewed
Jan 15, 2024
Remi-Gau
changed the title
5 tasks
ymzayek
reviewed
Jan 16, 2024
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
ymzayek
approved these changes
Jan 16, 2024
bthirion
reviewed
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
unrelated: update some of the doc string in datasets.func.py