[FIX] use proper grid spec when plotting carpet plots

[Remi-Gau]

• Closes Failure of carpet plot with matplotlib-3.9.0.dev0 #4278

Changes proposed in this pull request:

• fixes Failure of carpet plot with matplotlib-3.9.0.dev0 #4278
• runs numpy 2 tests on every PR

[github-actions]

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (abb80ff) to head (bf95b41).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4279      +/-   ##
==========================================
+ Coverage   91.85%   92.06%   +0.20%     
==========================================
  Files         144      144              
  Lines       16419    16422       +3     
  Branches     3434     3436       +2     
==========================================
+ Hits        15082    15119      +37     
+ Misses        792      761      -31     
+ Partials      545      542       -3     

Flag	Coverage Δ
macos-latest_3.10_test_plotting	91.85% <ø> (?)
macos-latest_3.11_test_plotting	91.85% <ø> (+<0.01%)	⬆️
macos-latest_3.8_test_plotting	91.81% <ø> (?)
macos-latest_3.9_test_plotting	91.82% <ø> (?)
ubuntu-latest_3.10_test_plotting	91.85% <ø> (+<0.01%)	⬆️
ubuntu-latest_3.11_test_plotting	91.85% <ø> (?)
ubuntu-latest_3.8_test_min	68.93% <ø> (?)
ubuntu-latest_3.8_test_plot_min	91.56% <ø> (?)
ubuntu-latest_3.8_test_plotting	91.81% <ø> (?)
windows-latest_3.11_test_plotting	91.83% <ø> (?)
windows-latest_3.12_test_plotting	91.83% <ø> (?)
windows-latest_3.8_test_plotting	91.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bthirion]

Thx for tackling this !

[bthirion]

oops, this seems to be unrelated.

[Remi-Gau]

Actually this is intentional: this is the 3rd time that I have had to go and manually check in the action tab to see if something numpy2 related was broken. I'd rather have this check run regularly for better automatic early detection.

By doing this it will be checked with every PR: this would also ensure that every PR does not bring changes that would be numpy2 incompatible.

[bthirion]

This is incompatible with latest mpl ?

[Remi-Gau]

nope this is because if you run the example as a script the figures closes right away and you do not have time for proper visual inspection