SpaceNet (this PR succeeds PR #219) #657
Conversation
|
Wondering whether it may be useful to squash all commits before you start editing in there again. "Commits" tab is complaining about this PR being big ;) Squashing should make it easier to keep this PR rebased while you finalize it. Unless of course you are considering cherry-picking or removing some commits, but that doesn't seem necessary. |
|
On Tue, Jul 14, 2015 at 10:48 AM, eickenberg notifications@github.com
DED |
|
As you wish. It would have been a good opportunity to get rid of the merges from master that you did along the way, which make rebasing impossible. That was my main concern. |
|
Good point. This is the workaround I was just about to adopt. The history is simply too big and too dirty. Squashing, rebasing, etc. here would take ages, and all this just to safe a few pages of more-harmful-than-useful code history. I'm copying the files to a fresh branch forked-off the upstream's master (nilearn/nilearn master), and then PR it. The old branch will still be available for histological purposes (if need be). |
dohmatob
force-pushed
the
sparse-models
branch
3 times, most recently
from
5023da5
to
0cf4f6e
Compare
| a principled way. | ||
| - Continuation is used along the regularization path, where the | ||
| solution of the optimization problem for a given value of the | ||
| regularization parameter `alpha` is used to used as initialization |
dohmatob
force-pushed
the
sparse-models
branch
2 times, most recently
from
cb39f7f
to
245ccd8
Compare
| return energy, grad | ||
|
|
||
|
|
||
| def tv_l1_from_gradient(spatial_grad): |
There was a problem hiding this comment.
with a leading underscore (these are rather low-level functions, of which users should not be aware)
…lassifier is used in mixed gambles
|
As agreed, I am going to merge this PR now. I lock it during the process. |
|
I created micro issues for the remaining comments. For the future: please try to break this kind of PR into smaller ones. For now: Great job, let's celebrate before being invaded by bugs 👯 Clicking the button! |
SpaceNet (this PR succeeds PR #219)
|
Champagne! 🍷 |
|
gr8! ✌️ 🍷 🍷 🍷 |
|
On Wed, Jul 29, 2015 at 12:28 AM, Alexandre Abraham <
DED |
|
Oh boy what a suspense!
Great job Elvis!
|
|
Yeah man :) |
This PR succeeds PR #219 (aka unicorn factory). All discussions should be done here henceforth. #219 is now classified, and should be referred to solely for histological purposes.