Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix broken doc build #3744

Merged
merged 2 commits into from Jun 6, 2023
Merged

[DOC] Fix broken doc build #3744

merged 2 commits into from Jun 6, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Jun 5, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #3744 (11305a5) into main (6085633) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3744   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         139      139           
  Lines       16572    16572           
  Branches     3236     3236           
=======================================
  Hits        15175    15175           
  Misses       1394     1394           
  Partials        3        3           
Impacted Files Coverage Δ
nilearn/plotting/img_plotting.py 94.52% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ymzayek
Copy link
Member Author

ymzayek commented Jun 6, 2023

Merging this to green the dev doc build. The other failures are unrelated

@ymzayek ymzayek merged commit 7e7e1b6 into nilearn:main Jun 6, 2023
26 of 29 checks passed
@ymzayek ymzayek deleted the fix-docbuild branch June 6, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant