Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] add lint recipe to make file #3758

Merged
merged 5 commits into from Jun 26, 2023
Merged

Conversation

Remi-Gau
Copy link
Collaborator

Closes #3756

Changes proposed in this pull request:

  • add lint recipe to make file
  • move linting dependencies to the [dev] install group

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau Remi-Gau marked this pull request as ready for review June 15, 2023 11:36
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #3758 (44aa39f) into main (6a576e5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3758   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         139      139           
  Lines       16554    16562    +8     
  Branches     3230     3229    -1     
=======================================
+ Hits        15172    15180    +8     
  Misses       1379     1379           
  Partials        3        3           

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as draft June 15, 2023 12:48
@Remi-Gau
Copy link
Collaborator Author

complete after #3759 is merged

@Remi-Gau Remi-Gau changed the title [MAINT] add lint recipe ot make file [MAINT] add lint recipe to make file Jun 15, 2023
@Remi-Gau Remi-Gau marked this pull request as ready for review June 20, 2023 05:57
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thx!

@Remi-Gau Remi-Gau merged commit c90bf61 into nilearn:main Jun 26, 2023
26 of 29 checks passed
@Remi-Gau Remi-Gau deleted the maint/make_lint branch June 26, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add make recipe to run all linting tool at once
2 participants