Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] remove test install with python 2.7 workflow #3768

Merged
merged 2 commits into from Jun 20, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jun 19, 2023

Closes #3767

Changes proposed in this pull request:

  • remove test install with python 2.7 workflow

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #3768 (2fe496c) into main (b2562d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3768   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         139      139           
  Lines       16591    16591           
  Branches     3244     3244           
=======================================
  Hits        15198    15198           
  Misses       1390     1390           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau
Copy link
Collaborator Author

@Remi-Gau Remi-Gau changed the title [MAINT] use a github workflow to test install [MAINT] remove test install with python 2.7 workflow Jun 19, 2023
@Remi-Gau Remi-Gau marked this pull request as ready for review June 19, 2023 22:40
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe to remove. Re #3767 (comment). I think if someone tries to do this and does so successfully we will hear about it because of other issues that will come up

@Remi-Gau Remi-Gau merged commit 06375b9 into nilearn:main Jun 20, 2023
28 checks passed
@Remi-Gau Remi-Gau deleted the maint/rm_test_install_2.7 branch June 20, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on azure: spec 2.7 for architecture x64 did not match any version
2 participants