[FIX] Make load_confounds' confounds file selection more generic

[tsalo]

Closes #3792.

Changes proposed in this pull request:

• Build candidate confounds filenames from entities in the image files. The only value that is hardcoded is "desc-confounds".
• Update tests to cover more cases.
  • The tests that would have failed before are test_get_file_name[True-_desc-confounds_regressors-part] and test_get_file_name[False-_desc-confounds_timeseries-part].

[github-actions]

👋 @tsalo Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[Remi-Gau]

For the test I think I had modified the functions to generate dummy datasets to accommodate more bids derivatives entities.

Maybe this can help.

[codecov]

Codecov Report

Merging #3794 (8888ef1) into main (089a1a0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
+ Coverage   91.52%   91.54%   +0.02%     
==========================================
  Files         133      133              
  Lines       15561    15598      +37     
  Branches     3229     3245      +16     
==========================================
+ Hits        14242    14279      +37     
  Misses        772      772              
  Partials      547      547              

Flag	Coverage Δ
macos-latest_3.10	?
macos-latest_3.11	?
macos-latest_3.8	91.43% <100.00%> (+0.02%)	⬆️
macos-latest_3.9	91.43% <100.00%> (+0.02%)	⬆️
ubuntu-latest_3.10	91.46% <100.00%> (+0.02%)	⬆️
ubuntu-latest_3.11	?
ubuntu-latest_3.8	?
ubuntu-latest_3.9	?
windows-latest_3.10	91.40% <100.00%> (+0.02%)	⬆️
windows-latest_3.11	91.40% <100.00%> (+0.02%)	⬆️
windows-latest_3.8	91.37% <100.00%> (+0.02%)	⬆️
windows-latest_3.9	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...n/interfaces/fmriprep/tests/test_load_confounds.py	98.34% <ø> (ø)
nilearn/interfaces/fmriprep/tests/utils.py	100.00% <ø> (ø)
...ilearn/interfaces/fmriprep/load_confounds_utils.py	100.00% <100.00%> (ø)
...rfaces/fmriprep/tests/test_load_confounds_utils.py	100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tsalo]

@Remi-Gau Thanks! I think I used the modified functions correctly.

[Remi-Gau]

Main thing would be to extract into a function the part that generates the list of candidates files.

[htwangtw]

LGTM just one minor thing to refactor the test

[htwangtw]

LGTM!

[Remi-Gau]

Thanks @tsalo