Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FMT] apply black to maskers - part 1 #3795

Merged
merged 7 commits into from Jul 4, 2023
Merged

Conversation

Remi-Gau
Copy link
Collaborator

Relates to #2528

Changes proposed in this pull request:

  • update configs to include nilearn/maskers
  • apply black

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau Remi-Gau marked this pull request as ready for review June 30, 2023 07:02
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3795 (bcfe354) into main (186845c) will not change coverage.
The diff coverage is 96.72%.

@@           Coverage Diff           @@
##             main    #3795   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         133      133           
  Lines       15561    15561           
  Branches     3229     3229           
=======================================
  Hits        14242    14242           
  Misses        772      772           
  Partials      547      547           
Flag Coverage Δ
macos-latest_3.10 91.44% <96.72%> (?)
macos-latest_3.11 91.44% <96.72%> (?)
macos-latest_3.8 91.41% <96.72%> (?)
macos-latest_3.9 91.41% <96.72%> (?)
ubuntu-latest_3.10 91.44% <96.72%> (?)
ubuntu-latest_3.11 91.44% <96.72%> (ø)
ubuntu-latest_3.8 91.41% <96.72%> (?)
ubuntu-latest_3.9 91.41% <96.72%> (ø)
windows-latest_3.10 91.38% <96.72%> (?)
windows-latest_3.11 91.38% <96.72%> (ø)
windows-latest_3.8 91.35% <96.72%> (ø)
windows-latest_3.9 91.35% <96.72%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nilearn/maskers/multi_nifti_masker.py 93.18% <94.11%> (ø)
nilearn/maskers/base_masker.py 89.74% <94.44%> (ø)
nilearn/maskers/_masker_validation.py 100.00% <100.00%> (ø)
nilearn/maskers/multi_nifti_labels_masker.py 95.65% <100.00%> (ø)
nilearn/maskers/multi_nifti_maps_masker.py 95.65% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit aece81b into nilearn:main Jul 4, 2023
28 checks passed
@Remi-Gau Remi-Gau deleted the black branch July 4, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants