Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "First draft of surface stuff after discussion during meetings & drop-in hours" #3848

Merged
merged 1 commit into from Jul 19, 2023
Merged

Revert "First draft of surface stuff after discussion during meetings & drop-in hours" #3848

merged 1 commit into from Jul 19, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Jul 19, 2023

Reverts #3799

@ymzayek ymzayek marked this pull request as ready for review July 19, 2023 18:44
@ymzayek ymzayek merged commit e002d24 into main Jul 19, 2023
25 checks passed
@ymzayek ymzayek deleted the revert-3799-surface_image branch July 19, 2023 18:45
@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

jeromedockes added a commit to jeromedockes/nilearn that referenced this pull request Jul 20, 2023
@jeromedockes
Revert "Revert "First draft of surface stuff after discussion during …
1728c0b 
…meetings & drop-in hours" (nilearn#3848)"

This reverts commit e002d24.
Remi-Gau pushed a commit that referenced this pull request Sep 28, 2023
@jeromedockes @ymzayek
SurfaceImage and maskers (#3856)
89f4642 
* Revert "Revert "First draft of surface stuff after discussion during meetings & drop-in hours" (#3848)"

This reverts commit e002d24.

* Add tests for datasets

* Simplify test

* Add tests for io functions

* Remove print

* Add masker tests

* Fix isort

* Use fsaverage shipped with nilearn for tests

* Add test data for surface image classes

* Specify dtype for fake mesh data

* check data and mesh have the same keys

* change order data, mesh -> mesh, data

to match what was done in the old surface module

* add some checks on mesh & data keys and shapes + add mask_img to SurfaceMasker

* start adding tests

* add some tests for SurfaceMasker

* io tests

* formatting

* add warnings about experimental module

* run precommit

* Update nilearn/experimental/surface/_io.py

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>

* Update nilearn/experimental/surface/_io.py

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>

* Update nilearn/experimental/surface/tests/test_io.py

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>

* Add docstrings

* Add whatsnew

---------

Co-authored-by: ymzayek <yasmin.mzayek@inria.fr>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ymzayek