New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] use tmp_path fixture in tests that do not depend on fake fmri data generation #3893
Conversation
Remi-Gau
commented
Aug 5, 2023
- relates to improve handling of temporary files during testing #3726
- extracted from [WIP] rely more on tmp_path in testing Do Not REVIEW [WIP] rely more on tmp_path in testing Do Not REVIEW #3891
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3893 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 134 134
Lines 15751 15751
Branches 3281 3281
=======================================
Hits 14429 14429
Misses 772 772
Partials 550 550
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thx! Just need to resolve the conflict