[FIX] Fix overlapping titles for plot_matrix function

[ymzayek]

• Relates to [DOC] Update and improve examples in nilearn documentation #3728

Changes proposed in this pull request:

• Simplify how title is added to matrix plots and make use of tight_layout for automatic adjustment
• Update relevant tests

Relevant to the following examples:

• https://nilearn.github.io/dev/auto_examples/03_connectivity/plot_sphere_based_connectome.html#
  • after fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/03_connectivity/plot_sphere_based_connectome.html#connectome-extracted-from-dosenbach-s-atlas
• https://nilearn.github.io/dev/auto_examples/02_decoding/plot_haxby_multiclass.html#
  • after fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/02_decoding/plot_haxby_multiclass.html#plot-a-confusion-matrix
• https://nilearn.github.io/dev/auto_examples/03_connectivity/plot_inverse_covariance_connectome.html#
  • after fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/03_connectivity/plot_inverse_covariance_connectome.html#display-the-connectome-matrix
• https://nilearn.github.io/dev/auto_examples/03_connectivity/plot_extract_regions_dictlearning_maps.html#
  • after fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/03_connectivity/plot_extract_regions_dictlearning_maps.html#plot-resulting-connectomes
• https://nilearn.github.io/dev/auto_examples/03_connectivity/plot_signal_extraction.html#
  • after fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/03_connectivity/plot_signal_extraction.html#compute-and-display-a-correlation-matrix
• https://nilearn.github.io/dev/auto_examples/03_connectivity/plot_multi_subject_connectome.html#
  • after fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/03_connectivity/plot_multi_subject_connectome.html#displaying-results
• https://nilearn.github.io/dev/auto_examples/01_plotting/plot_visualize_megatrawls_netmats.html#
  • After fix: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/01_plotting/plot_visualize_megatrawls_netmats.html#visualization

[github-actions]

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[codecov]

Codecov Report

Merging #3899 (38751aa) into main (45187e7) will decrease coverage by 0.08%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3899      +/-   ##
==========================================
- Coverage   91.60%   91.53%   -0.08%     
==========================================
  Files         134      134              
  Lines       15751    15750       -1     
  Branches     3281     3280       -1     
==========================================
- Hits        14429    14417      -12     
- Misses        772      784      +12     
+ Partials      550      549       -1     

Flag	Coverage Δ
macos-latest_3.10	91.53% <100.00%> (-0.01%)	⬇️
macos-latest_3.11	91.53% <100.00%> (-0.01%)	⬇️
macos-latest_3.8	91.49% <100.00%> (-0.01%)	⬇️
macos-latest_3.9	91.49% <100.00%> (?)
ubuntu-latest_3.10	91.53% <100.00%> (-0.01%)	⬇️
ubuntu-latest_3.11	91.53% <100.00%> (-0.01%)	⬇️
ubuntu-latest_3.8	91.49% <100.00%> (-0.01%)	⬇️
ubuntu-latest_3.9	91.49% <100.00%> (-0.01%)	⬇️
windows-latest_3.10	91.47% <100.00%> (-0.01%)	⬇️
windows-latest_3.11	91.47% <100.00%> (-0.01%)	⬇️
windows-latest_3.8	91.43% <100.00%> (-0.01%)	⬇️
windows-latest_3.9	91.43% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
nilearn/plotting/matrix_plotting.py	93.50% <100.00%> (-0.03%)	⬇️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ymzayek]

For review see full build here: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/index.html

This did break a test that checks the title, however it's using a private attribute of matplotlib.image.AxesImage. I updated the test in commit 38751aa. However, maybe this needs to be dealt with in a different way or keep the original text method but configure the parameters better. What do others think?

[Remi-Gau]

edited the top comment with links to the after version of each plot

[Remi-Gau]

For review see full build here: https://output.circle-artifacts.com/output/job/a9439351-08ed-476f-808e-6cb69147e4ce/artifacts/0/dev/auto_examples/index.html

This did break a test that checks the title, however it's using a private attribute of matplotlib.image.AxesImage. I updated the test in commit 38751aa. However, maybe this needs to be dealt with in a different way or keep the original text method but configure the parameters better. What do others think?

TBF I think this is fine as it is. 😃