Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Prevent Actions workflows from running on people's forks #3900

Merged
merged 4 commits into from Aug 10, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Aug 10, 2023

  • Closes #

I noticed all these workflows will get triggered when people work on PRs from the main branch of their fork or any time they push to their main branch.

@Remi-Gau
Copy link
Collaborator

good catch

I would still let the fast CI workflows run on forks ,no?

  • black
  • flake8
  • codespell
  • fstrings

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@ymzayek
Copy link
Member Author

ymzayek commented Aug 10, 2023

I would still let the fast CI workflows run on forks ,no?

Ok that's fine

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3900 (93a7062) into main (6fe4c71) will increase coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3900      +/-   ##
==========================================
+ Coverage   91.53%   91.60%   +0.06%     
==========================================
  Files         134      134              
  Lines       15751    15751              
  Branches     3281     3281              
==========================================
+ Hits        14418    14429      +11     
+ Misses        784      772      -12     
- Partials      549      550       +1     
Flag Coverage Δ
macos-latest_3.10 ?
macos-latest_3.11 ?
macos-latest_3.8 ?
macos-latest_3.9 ?
ubuntu-latest_3.10 91.53% <ø> (ø)
ubuntu-latest_3.11 91.53% <ø> (ø)
ubuntu-latest_3.8 91.49% <ø> (ø)
ubuntu-latest_3.9 91.49% <ø> (ø)
windows-latest_3.10 91.47% <ø> (ø)
windows-latest_3.11 ?
windows-latest_3.8 91.43% <ø> (ø)
windows-latest_3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit 87efd91 into nilearn:main Aug 10, 2023
27 of 28 checks passed
@ymzayek ymzayek deleted the limit_ci_repo branch August 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants