Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Remove MKL dependency for the documentation build dependencies #3920

Merged
merged 1 commit into from Aug 22, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Aug 22, 2023

Changes proposed in this pull request:

  • Remove mkl doc dependency

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3920 (00e57a1) into main (84984de) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
+ Coverage   91.72%   91.73%   +0.01%     
==========================================
  Files         134      134              
  Lines       15738    15738              
  Branches     3275     3275              
==========================================
+ Hits        14435    14437       +2     
+ Misses        759      758       -1     
+ Partials      544      543       -1     
Flag Coverage Δ
macos-latest_3.10 91.64% <ø> (ø)
macos-latest_3.11 91.64% <ø> (?)
macos-latest_3.8 91.60% <ø> (?)
macos-latest_3.9 91.60% <ø> (?)
ubuntu-latest_3.10 91.64% <ø> (ø)
ubuntu-latest_3.11 ?
ubuntu-latest_3.8 ?
ubuntu-latest_3.9 91.60% <ø> (ø)
windows-latest_3.10 91.58% <ø> (?)
windows-latest_3.11 91.58% <ø> (?)
windows-latest_3.8 91.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ymzayek
Copy link
Member Author

ymzayek commented Aug 22, 2023

This seems good to go to me. Will merge if nobody has any comments or questions

@Remi-Gau
Copy link
Collaborator

This seems good to go to me. Will merge if nobody has any comments or questions

Go for it

@ymzayek ymzayek merged commit 8b05ece into nilearn:main Aug 22, 2023
29 checks passed
@ymzayek ymzayek deleted the remove_mkl branch August 22, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cannot install mkl (doc dependency) on Mac M1 Sillicon chip
2 participants