Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update handling of matplotlib ax overwrite deprecation #3965

Merged
merged 1 commit into from Sep 12, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Sep 12, 2023

  • Closes none

Resets handling of matplotlib deprecation. With the newest matplotlib v3.7.3 release, this change is causing the CI failures. I have to see if I handled it incorrectly or if it's a new bug on their side. For the time being, will merge this PR so the CI passes

Edit: see comment below

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #3965 (b8d8828) into main (d2779b9) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3965      +/-   ##
==========================================
- Coverage   91.78%   91.78%   -0.01%     
==========================================
  Files         134      134              
  Lines       15772    15772              
  Branches     3284     3284              
==========================================
- Hits        14477    14476       -1     
- Misses        751      752       +1     
  Partials      544      544              
Flag Coverage Δ
ubuntu-latest_3.10 91.70% <0.00%> (?)
ubuntu-latest_3.8 91.67% <0.00%> (?)
ubuntu-latest_3.9 91.67% <0.00%> (?)
windows-latest_3.10 91.64% <0.00%> (?)
windows-latest_3.11 91.64% <0.00%> (?)
windows-latest_3.9 91.61% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nilearn/plotting/img_plotting.py 89.13% <0.00%> (-0.21%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ymzayek
Copy link
Member Author

ymzayek commented Sep 12, 2023

Ok maybe it was fine the way it was but I didn't use good arguments for _compare_version

@ymzayek ymzayek changed the title [MAINT] Remove handling of matplotlib ax overwrite deprecation [MAINT] Update handling of matplotlib ax overwrite deprecation Sep 12, 2023
@ymzayek ymzayek merged commit 38fb768 into nilearn:main Sep 12, 2023
28 of 29 checks passed
@ymzayek ymzayek deleted the mpl-remove-keyerror branch September 12, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant