Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] reduce font size for headings #3978

Merged
merged 1 commit into from Sep 15, 2023

Conversation

Remi-Gau
Copy link
Collaborator

Technically this does not quite solve the overflow but indirectly helps by making the headings smaller.

This was especially needed on smaller viewports.

Changes proposed in this pull request:

  • reduce headings size for different view ports

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau
Copy link
Collaborator Author

I suspect there may be a way to also avoid things like this 👍🏾

image

by removing the prefix in the nilearn.glm in the local table of content but I think this may require playing with jinja templating and arcane sphinx things that are not worth the effort

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #3978 (153b8a5) into main (d1fadd4) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3978      +/-   ##
==========================================
- Coverage   91.79%   91.76%   -0.03%     
==========================================
  Files         134      134              
  Lines       15776    15781       +5     
  Branches     3286     3289       +3     
==========================================
  Hits        14482    14482              
- Misses        751      755       +4     
- Partials      543      544       +1     
Flag Coverage Δ
macos-latest_3.10 91.67% <ø> (-0.03%) ⬇️
macos-latest_3.11 91.67% <ø> (-0.03%) ⬇️
macos-latest_3.8 91.64% <ø> (-0.03%) ⬇️
macos-latest_3.9 91.64% <ø> (-0.03%) ⬇️
ubuntu-latest_3.10 91.67% <ø> (-0.03%) ⬇️
ubuntu-latest_3.11 91.67% <ø> (-0.03%) ⬇️
ubuntu-latest_3.8 91.64% <ø> (-0.03%) ⬇️
ubuntu-latest_3.9 91.64% <ø> (-0.03%) ⬇️
windows-latest_3.10 91.62% <ø> (?)
windows-latest_3.11 91.62% <ø> (-0.03%) ⬇️
windows-latest_3.8 91.58% <ø> (-0.03%) ⬇️
windows-latest_3.9 91.58% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau
Copy link
Collaborator Author

Fullwidth (1920px):

Before

image

After

image

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Sep 14, 2023

Width 1090px

Before
image

After
image

@Remi-Gau
Copy link
Collaborator Author

width 390px

Before
image

After
image

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Remi-Gau Remi-Gau merged commit 29bc87e into nilearn:main Sep 15, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the font_size_heading branch September 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text overflow in documentation html rendering
2 participants