Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Allow setting vmin in plot_glass_brain and plot_stat_map #3993

Merged
merged 25 commits into from
Oct 11, 2023
Merged

[ENH] Allow setting vmin in plot_glass_brain and plot_stat_map #3993

merged 25 commits into from
Oct 11, 2023

Commits on Sep 12, 2023

  1. add vmin to plot_glass_brain

    @michellewang
    michellewang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9b4ba9e View commit details
    Browse the repository at this point in the history

  2. update thresholding

    @michellewang
    michellewang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    943033a View commit details
    Browse the repository at this point in the history

  3. add test for plot_glass_brain

    @michellewang
    michellewang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e26c79e View commit details
    Browse the repository at this point in the history

  4. update _get_colorbar_and_data_ranges() and tests

    @michellewang
    michellewang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    df374fb View commit details
    Browse the repository at this point in the history

  5. use half of colormap if plot_abs is True

    @michellewang
    michellewang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    bf597fa View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. update docstrings

    @michellewang
    michellewang committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6d121f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. fix plot_abs and nan vmin/vmax

    @michellewang
    michellewang committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    65a518f View commit details
    Browse the repository at this point in the history

  2. minor refactoring

    @michellewang
    michellewang committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0f49ef7 View commit details
    Browse the repository at this point in the history

  3. add example with vmin

    @michellewang
    michellewang committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7da66f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. fix flake8 and do thresholding after transform_to_2d

    @michellewang
    michellewang committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    070d724 View commit details
    Browse the repository at this point in the history

  2. update example

    @michellewang
    michellewang committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    174366e View commit details
    Browse the repository at this point in the history

  3. attempt to increase test coverage

    @michellewang
    michellewang committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    751d054 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 3084/more_vmin

    @michellewang
    michellewang committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1c3bb48 View commit details
    Browse the repository at this point in the history

  5. add changelog entry

    @michellewang
    michellewang committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    35f73d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge branch 'main' into 3084/more_vmin

    @michellewang
    michellewang committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8dff80f View commit details
    Browse the repository at this point in the history

  2. move default="auto" for symmetric_cbar to substitution string

    @michellewang
    michellewang committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d420580 View commit details
    Browse the repository at this point in the history

  3. remove redundant absolute value transformation

    @michellewang
    michellewang committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    10c1ff0 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge remote-tracking branch 'upstream/main' into 3084/more_vmin

    @michellewang
    michellewang committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    fdfbb9f View commit details
    Browse the repository at this point in the history

  2. attempt to increase test coverage

    @michellewang
    michellewang committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a082c03 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. update docs for symmetric_cbar

    @michellewang
    michellewang committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3a9b38e View commit details
    Browse the repository at this point in the history

  2. replace error with warning for plot_abs/vmin case

    @michellewang
    michellewang committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a49efe8 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into 3084/more_vmin

    @michellewang
    michellewang committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    56ab1f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. allow arbitrary vmin even if plot_abs is True

    @michellewang
    michellewang committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b04548e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Apply suggestions from code review

    ymzayek committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c45e8cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into HEAD

    ymzayek committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    58f717d View commit details
    Browse the repository at this point in the history