Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] update pytest config #4009

Merged
merged 1 commit into from Sep 28, 2023
Merged

[MAINT] update pytest config #4009

merged 1 commit into from Sep 28, 2023

Conversation

Remi-Gau
Copy link
Collaborator

Changes proposed in this pull request:

  • set xfail_strict to true as we do have a few xfail tests
  • use --strict-config
  • use --strict-markers
  • use -ra

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4009 (96c41d4) into main (5674c3e) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4009      +/-   ##
==========================================
- Coverage   91.77%   91.70%   -0.07%     
==========================================
  Files         134      134              
  Lines       15795    15795              
  Branches     3299     3299              
==========================================
- Hits        14496    14485      -11     
- Misses        755      767      +12     
+ Partials      544      543       -1     
Flag Coverage Δ
macos-latest_3.10 91.69% <ø> (ø)
macos-latest_3.11 91.69% <ø> (ø)
macos-latest_3.8 91.65% <ø> (ø)
macos-latest_3.9 91.65% <ø> (ø)
ubuntu-latest_3.10 91.69% <ø> (ø)
ubuntu-latest_3.11 91.69% <ø> (ø)
ubuntu-latest_3.8 91.65% <ø> (ø)
ubuntu-latest_3.9 91.65% <ø> (ø)
windows-latest_3.10 91.63% <ø> (ø)
windows-latest_3.11 91.63% <ø> (ø)
windows-latest_3.8 91.59% <ø> (ø)
windows-latest_3.9 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review September 25, 2023 11:09
@Remi-Gau Remi-Gau merged commit 04892a0 into nilearn:main Sep 28, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the pytest_cfg branch November 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants