Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix spelling #4026

Merged
merged 2 commits into from Oct 4, 2023
Merged

[FIX] fix spelling #4026

merged 2 commits into from Oct 4, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 4, 2023

Changes proposed in this pull request:

  • fix typos caught by codespell

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau Remi-Gau marked this pull request as ready for review October 4, 2023 09:54
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #4026 (7e6b62a) into main (9e5706d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4026   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         145      145           
  Lines       16230    16230           
  Branches     3367     3367           
=======================================
  Hits        14888    14888           
  Misses        797      797           
  Partials      545      545           
Flag Coverage Δ
macos-latest_3.10 91.65% <ø> (ø)
macos-latest_3.11 91.65% <ø> (ø)
macos-latest_3.8 91.61% <ø> (ø)
macos-latest_3.9 91.61% <ø> (ø)
ubuntu-latest_3.10 91.65% <ø> (ø)
ubuntu-latest_3.11 91.65% <ø> (ø)
ubuntu-latest_3.8 91.61% <ø> (ø)
ubuntu-latest_3.9 91.61% <ø> (ø)
windows-latest_3.10 91.59% <ø> (ø)
windows-latest_3.11 91.59% <ø> (?)
windows-latest_3.8 91.55% <ø> (ø)
windows-latest_3.9 91.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nilearn/_utils/exceptions.py 100.00% <ø> (ø)
nilearn/decoding/fista.py 85.18% <ø> (ø)
nilearn/decomposition/_base.py 94.87% <ø> (ø)
nilearn/glm/regression.py 78.43% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @Remi-Gau

@ymzayek ymzayek merged commit b3385c5 into nilearn:main Oct 4, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the spell branch November 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespell update is catching new mistakes
2 participants