-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] using tox to test in different environments #4029
Merged
Merged
Changes from 42 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
30b6800
try using tox
Remi-Gau 3999d67
fix
Remi-Gau 9623301
remove old test workflow
Remi-Gau b075425
[DATALAD] Recorded changes
Remi-Gau 8ae39c2
skip doc test for now
Remi-Gau ef4bdfa
rm github env
Remi-Gau 71088a0
skip test doc
Remi-Gau baaa385
fix typo
Remi-Gau de69216
change name steps
Remi-Gau c265804
rename
Remi-Gau 7aabbc0
typo
Remi-Gau 60caea4
do not use conda
Remi-Gau 06e82aa
test doc
Remi-Gau fc99673
add set up tools
Remi-Gau b733de1
install setuptools
Remi-Gau c8970e3
move build type check
Remi-Gau 38419c9
try some other tests first
Remi-Gau f4dbbaa
Merge remote-tracking branch 'upstream/main' into tox
Remi-Gau 82028cd
remove testing wxorkflow
Remi-Gau 50a95b1
add comment
Remi-Gau 28eac9f
parametrize tests
Remi-Gau 8cf308e
use extras
Remi-Gau 68d4bdb
flake8
Remi-Gau e79fd22
try setting username for failing tests
Remi-Gau 81176b3
skip restore on partial builds
Remi-Gau 37007fd
refactor
Remi-Gau 14eba97
simplify linting by relying on pre-commit
Remi-Gau 422b2c8
Merge remote-tracking branch 'upstream/main' into tox
Remi-Gau 3bcabfb
update doc
Remi-Gau d5aacde
typo
Remi-Gau efe3ac7
fix fixture
Remi-Gau c5ed99b
Update doc/maintenance.rst
Remi-Gau 01c37aa
pass env variables and refactor
Remi-Gau b7d4772
rm fixture
Remi-Gau 18a8ebb
refactor and get coverage in all cases
Remi-Gau 0815ccc
Apply suggestions from code review
Remi-Gau d066147
modify commands to get coverage in all env
Remi-Gau 4cfeb98
add description
Remi-Gau 6cb5e8f
fix typo
Remi-Gau 333d0a5
update names
Remi-Gau 3b6a3ca
do not use 3.8 for testing with latest
Remi-Gau c4f5645
allow to pass extra arguments to test env$
Remi-Gau 92739db
Update .github/workflows/build-docs.yml
Remi-Gau d5fc04c
run test by calling pytest directly
Remi-Gau 497ac61
try to fix coverage
Remi-Gau 747ec9f
test python 3.8 with latest dependencies
Remi-Gau b68709a
rm coverage.xml
Remi-Gau 6d2e3ee
Merge remote-tracking branch 'upstream/main' into tox
Remi-Gau 9bad1b9
try tox coniditional kaleido install
Remi-Gau 7abc33a
update changelog
Remi-Gau e136ccd
add comment in tox.ini
Remi-Gau File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change the paths? it takes nilearn main as root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use the the link locally (clicking it in VS code) and it failed so I modified to make it work.
I assumed that they would fail in github but you are correct that they work on the main branch.
Just to check they also work on the branch for this PR so changing them should not affect people browsing the repo.
https://github.com/Remi-Gau/nilearn/blob/tox/.github/workflows/README.md