New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Rename and move testing utilities under tests directory in each module #4047
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 91.59% 91.56% -0.04%
==========================================
Files 145 143 -2
Lines 16238 16057 -181
Branches 3376 3332 -44
==========================================
- Hits 14874 14703 -171
+ Misses 817 811 -6
+ Partials 547 543 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What's you take on this one: https://github.com/nilearn/nilearn/blob/main/nilearn/_utils/testing.py ? I suspect it is in a private module and contains testing utilities used for several other modules so it is fine where it is and named as it is. Just want to make sure we are on the same page. |
Yes that's what I was thinking too. It doesn't fit the pattern of the others that are private to the testing of a specific module (with one or two functions being an exception like the generate_surf in nilearn/surface/tests/_testing being used in plotting/tests/test_surf_plotting) |
OK we agree on this. Good to me then. Let's merge. Thanks for taking care of this. This one has been itching my inner Marie Kondo for a while. |
Changes proposed in this pull request: