Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] minor pre-commit fix #4125

Merged
merged 2 commits into from Nov 30, 2023
Merged

[MAINT] minor pre-commit fix #4125

merged 2 commits into from Nov 30, 2023

Conversation

Remi-Gau
Copy link
Collaborator

  • update name of of one file to ignore in the precommit config (was renamed everywhere else but there)
  • minor RST fix flagged by pre-commit run -a

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c65177) 91.84% compared to head (b104bbe) 91.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
- Coverage   91.84%   91.80%   -0.05%     
==========================================
  Files         144      144              
  Lines       16224    16224              
  Branches     3377     3377              
==========================================
- Hits        14901    14894       -7     
- Misses        781      790       +9     
+ Partials      542      540       -2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.67% <ø> (ø)
macos-latest_3.11_test_plotting 91.67% <ø> (ø)
macos-latest_3.12_test_plotting 91.67% <ø> (ø)
macos-latest_3.8_test_plotting 91.63% <ø> (ø)
macos-latest_3.9_test_plotting ?
ubuntu-latest_3.10_test_plotting 91.67% <ø> (ø)
ubuntu-latest_3.11_test_plotting 91.67% <ø> (ø)
ubuntu-latest_3.12_test_plotting 91.67% <ø> (ø)
ubuntu-latest_3.12_test_pre 91.67% <ø> (ø)
ubuntu-latest_3.8_test_min ?
ubuntu-latest_3.8_test_plot_min 91.39% <ø> (ø)
ubuntu-latest_3.8_test_plotting 91.63% <ø> (ø)
ubuntu-latest_3.9_test_plotting 91.63% <ø> (ø)
windows-latest_3.10_test_plotting 91.64% <ø> (ø)
windows-latest_3.11_test_plotting 91.64% <ø> (ø)
windows-latest_3.12_test_plotting 91.64% <ø> (ø)
windows-latest_3.8_test_plotting 91.60% <ø> (ø)
windows-latest_3.9_test_plotting 91.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 570a65a into nilearn:main Nov 30, 2023
32 checks passed
@Remi-Gau Remi-Gau deleted the pre_commit branch November 30, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants