Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Make NiStats terms compatible with BIDS terms #216

Closed
kchawla-pi opened this issue Sep 7, 2018 · 13 comments
Closed

Make NiStats terms compatible with BIDS terms #216

kchawla-pi opened this issue Sep 7, 2018 · 13 comments
Assignees

Comments

@kchawla-pi
Copy link
Collaborator

kchawla-pi commented Sep 7, 2018

PR #246

@kchawla-pi
Copy link
Collaborator Author

Any suggestions where/how I should start finding the nistats terms which need replacement?

@bthirion
Copy link
Member

key concepts are: onsets, confounds, fMRI file, anatomical files. Try and check those, e.g. in first_level_model API.

@kchawla-pi
Copy link
Collaborator Author

kchawla-pi commented Sep 17, 2018

@effigies @tyarkoni @satra @chrisfilo
Feel free to chime in and add any term that you have encountered that is contrary to BIDS spec, where you see it, etc

@kchawla-pi
Copy link
Collaborator Author

kchawla-pi commented Sep 18, 2018

@bthirion I made my attempt and I think someone with more experience with fMRI would be better suited for this task. @GaelVaroquaux suggested Juan or Anna Louisa, if not you.

Or maybe I can work with them, they can point and I can shoot.

@kchawla-pi
Copy link
Collaborator Author

I may replace paradigm with event during the course of working on issue #223
Don't let me delay your contribution to this, I will give precedence to your work on this issue.

@bthirion
Copy link
Member

Note that i don't have time to work muwh on nistats till next week :- (
Please go ahead.

@tyarkoni
Copy link

@kchawla-pi I've meant to contribute to the discussion and look at the code, but unfortunately I'm completely swamped for the next 2 weeks. Keep in mind that the core BIDS-Stat-Model spec will probably be finalized after the Stanford meeting next month, and at that point it'll be safer to lock in any changes that attempt to make nistats more BIDS compliant. I'll try and look at this before then though, if you haven't already finished the work.

@bthirion
Copy link
Member

bthirion commented Oct 4, 2018

I may replace paradigm with event during the course of working on issue #223
Don't let me delay your contribution to this, I will give precedence to your work on this issue.

@kchawla-pi Have you done / are you doing this ?

@kchawla-pi
Copy link
Collaborator Author

Soon as I prepare #234 for review, which should be today. Then I will start replacing the phrase paradigm with events in code and docs.

@kchawla-pi
Copy link
Collaborator Author

@tyarkoni Thanks Tal!

@kchawla-pi
Copy link
Collaborator Author

In some places in the documentation, the word paradigm is not literally interchangeable with events. I was thinking of using "sequence of events" or "events sequence" there.
Concerns?

@bthirion
Copy link
Member

bthirion commented Oct 5, 2018

No concern on my side.
I think we can use "experimental paradigm", that is not ambiguous. "paradigm" alone is ambiguous.

@kchawla-pi
Copy link
Collaborator Author

I am closing this issue, please file new issues for other term non-compliance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants