Support periodic jobs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jysandy
force-pushed
the
periodic-jobs
branch
from
c489a2e
to
39b26e7
Compare
This is done by wrapping the find and enqueue in a Carmine atomic block and watching the cron schedules key. Also adds a macro to wrap code in a Carmine transaction.
- Fix linter warnings - Rename and refactor a couple of functions
...to a maximum of 60 seconds. This will ensure that cron jobs are run on time.
Registering a cron entry with an existing name will cause the existing entry to be overwritten.
The default pool options in goose.brokers.redis.broker were failing this spec.
Cron entries are now registered in a hash map, keyed by their names. Their due times are maintained in a sorted set of due time epoch millis against their names.
Now, SCAN results are accessed through a lazy seq.
This is the latency from the time a cron job was supposed to be run to the time it was picked up.
jysandy
force-pushed
the
periodic-jobs
branch
from
0f2464f
to
5749adc
Compare
olttwa
force-pushed
the
periodic-jobs
branch
from
3de3b0d
to
24bfb48
Compare
olttwa
approved these changes
Sep 9, 2022
jysandy
commented
Sep 12, 2022
jysandy
commented
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52