Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add if-exists to DROP TABLE #24

Closed
arichiardi opened this issue Dec 3, 2018 · 2 comments
Closed

Add if-exists to DROP TABLE #24

arichiardi opened this issue Dec 3, 2018 · 2 comments

Comments

@arichiardi
Copy link
Contributor

Hi all!

It's been a while but I have another enhancement coming.

Basically I would like to have:

DROP TABLE IF EXISTS t1, t2, t3

There is one problem though, the current parameters to :drop-table are [_ tables], which means that if I add [_ if-exists tables] it will be a breaking change in the API.

What do you folks think about this? How should the api look like?
@arichiardi
Copy link
Contributor Author

Never mind I found the solution and it's not breaking 😄, see #25

@ukriish
Copy link
Contributor

ukriish commented Dec 4, 2018

This is something I missed adding and never got around to.

Will look at the PR, thanks @arichiardi!!

@ukriish ukriish closed this as completed in b7b0939 Dec 6, 2018
ukriish added a commit that referenced this issue Dec 6, 2018
@ukriish
Merge pull request #25 from arichiardi/drop-if-exists
955055d 
[Fix #24] Add :if-exists clause to :drop-table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukriish @arichiardi