Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable "All Read", "Feed Read", "Feeds Read" buttons #270

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

I have never needed the menu options to mark everything as read and actually I 
have pressed it twice by accident with catastrophic results.
So, I request an option to disable those (IMHO) annoyingly dangerous buttons, 
the default behavior would be as before.

I attach a patch with a possible solution, hoping this is enough to be in a 
next release.

Original issue reported on code.google.com by juan...@gmail.com on 9 Mar 2015 at 11:10

Attachments:

@nilsbraden
Copy link
Owner

Thank you for providing a patch, I did include it almost unchanged.

I also added the existing Dialog to a situation I forgot before. There is a Dialog which asks on the following occasions now:

  • Marking a category as read
  • Marking a virtual category as read
  • Marking all feeds within a category as read
  • Marking all articles as read when using "Show all articles for this category"

I attached a build with the current changes so you can try this. The next update will probably take some more days. You can download the build here: https://drive.google.com/open?id=0B2I5LDZK1kOEWHQtWE1zTWZUeDQ

nilsbraden added a commit that referenced this issue Mar 25, 2015
 - Fixed Issue #270: Option to disable "All Read", "Feed Read", "Feeds Read" buttons
 Thanks for providing a patch!

 - Added YesNoDialog to marking a feed as read if the current feed is a union of all feeds of a category
@deMattin
Copy link

deMattin commented Apr 2, 2015

I've liked the feature very much to mark categoies read without app asking me, if i really want.
The workflow now is much worse as before.
You should have the option to deactivate this dialog!
Please make this possible.

And with last update also the "mark category as read button" has gone away, if you tap on an article in tablet view and it is replaced by fav icon.
Mark as fav is not as often neccessary as Mark all read but I think, there's enough space for both icons.

I see this patch as a step backwards in workflow.
Please make this setable to get old workflow back for user, who know, where they tap on and do not need this annoying dialog.
I really want the app to do, what I tapped on without asking unneccessary questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants