Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see any entry on any folder, using any account #1882

Closed
L30Bola opened this issue Aug 26, 2017 · 13 comments
Closed

Can't see any entry on any folder, using any account #1882

L30Bola opened this issue Aug 26, 2017 · 13 comments

Comments

@L30Bola
Copy link

L30Bola commented Aug 26, 2017

Steps to reproduce

  1. Login as some non-admin user
  2. Create or just try to view some entry

Expected behaviour

Should be able to view the entry.

Actual behaviour

Can't see any entry, but it's possible to search for the entry.

Server configuration

Operating system:
CentOS 7.3.1611

Docker Version:
17.06-ce

Container Version:
teampass/teampass:latest

Don't know if it's relevant but the MySQL Server is another Docker container. It's using the latest 5.6 version available to a CentOS, which is 5.6.37.

Client configuration

Browser:
Google Chrome Version 60.0.3112.113 (Official Build) (64-bit)
Mozilla Firefox 55.0.2 (64-bit)

Operating system:
Fedora 26

@nilsteampassnet
Copy link
Owner

Has the user the role permitting to view those entries?

@L30Bola
Copy link
Author

L30Bola commented Aug 28, 2017

I tried with two users, both had permissions to view and edit the entries. I could even create a new entry and any user wouldn't see the entry, but the entry would appear if it was searched for.

@L30Bola
Copy link
Author

L30Bola commented Aug 28, 2017

I made a kinda-short video to try to show the bug (It's not listed): https://youtu.be/9auUGNNyfoM

@nilsteampassnet
Copy link
Owner

Thank you for the video.
Do you have any errors in the log?

@L30Bola
Copy link
Author

L30Bola commented Aug 28, 2017

I've seen the nginx config inside the container and it logs everything to stdout, so I'm attaching the Docker log here.
teampass-log.txt

@nilsteampassnet
Copy link
Owner

This seems to be the access.log file. It doesn't trace the errors, just the access operations.
Can you attach the php error log one?

@L30Bola
Copy link
Author

L30Bola commented Aug 29, 2017

Well, I'm trying to enable the error logging for PHP inside the container, since it's disabled by default.
image

I didn't find the php.ini, but I found a bunch of .ini files that appear to alter the PHP variables. So I edited it to add the following lines:

display_error = 1
error_log = /var/log/php/php-error.log
error_reporting = E_ALL
log_errors = 1
log_errors_max_len = 0

Then, It appeared to work, but the log file isn't being written. I tried to access some pages so some errors should be logged. Still no errors logged. So I restarted the TeamPass application container and now the interface shows me the following blank message:
image

After some little debugging I found that the error_reporting = E_ALL is the one that makes this blank message appear. And even with this blank message on the app interface, the error log is still empty.

@L30Bola
Copy link
Author

L30Bola commented Aug 31, 2017

So, I did a full build of the application image, instead of use the one provided by the teampass/teampass:latest, found on the Docker Hub. The differences being:

  • Used the Alpine image as base, instead the CentOS one;
  • Installed the latest PHP 5 version available: 5.6.31, provided by WebTatic Repos: https://webtatic.com/projects/yum-repository/
  • Instead oh Nginx, I used Apache, just for the sake of testing;

After the "installation" process, I cloned the TeamPass repo for, the latest version and tested. All seem working now.

Also, on my last reply on this issue, I said that the error_reporting = E_ALL was the the PHP variable which made the blank dialog appear. But I was wrong. After reading the PHP configuration, I found out that it's the display_errors = 1.
I still didn't find the problem on the official TeamPass Docker Image problem. I'll try to find the error and report here. :)

@nilsteampassnet
Copy link
Owner

Thank you for all the tests you did here.
I don't have much knowledge of Docker. My test consists here to install it and check that data is correct.
And this was the case but I'm loading it on Win10 machine.

@L30Bola
Copy link
Author

L30Bola commented Aug 31, 2017

Does TeamPass works with PHP 7.*? If yes, which PHP version do you recommend to use with TeamPass? 5, 7 or 7.1?

@L30Bola
Copy link
Author

L30Bola commented Sep 2, 2017

I tested with the latest version of PHP 5 (5.6.31), PHP 7.0 (7.0.23) and PHP 7.1 (7.1.9). They all worked well, without this bug. I tested them all on a CentOS Docker container. I'm not sure about this, but I'm guessing the problem is inside that Docker image that is being used as the base for the current TeamPass Docker image. Maybe some missing PHP dependency/module. I didn't make all the tests to be 100% sure about it though.

@troptop
Copy link

troptop commented Sep 6, 2017

Hi,

I had the same issue.
I updated the richarvey/nginx-php-fpm:1.3.5 instead of richarvey/nginx-php-fpm:1.2.1 version in the Teampass Dockerfile and build the container locally and it works

nilsteampassnet added a commit that referenced this issue Sep 6, 2017
Fix: issue on offline export
Fix for #1882
@L30Bola
Copy link
Author

L30Bola commented Sep 20, 2017

I'll close this Issue since the culprit appears to be the outdated php-fpm.

@L30Bola L30Bola closed this as completed Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants