Duo google auth fix #1471
Merged
Duo google auth fix #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development-API settings fixes
Problem: Upgrade script creates duplicates ldap_object_class entries when run, due to a bad query. Solution: This fixes the behavior, and also does a cleanup to remove any extra ldap_object_class=0 entries the script may have previously inserted. Duplicates can be prevented if teampass set the label to be a primary key: ALTER TABLE misc ADD PRIMARY KEY (intitule)
|
|
|
Thanks for this. I will merge as soon as my internet connection is back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id="2factors_authorization" is illegal (id selectors in HTML cannot start with a number, may break things). I changed this setting value globally to google_authorization (except in language files); this will also make the purpose clearer.
-install and upgrade scripts updated to convert existing 2factors settings (nothing breaks if upgrade script is not run; google just defaults to off)
2fa settings pages fixes:
Google auth name now has a save button, so it saves when expected
Google settings hidden when disabled
Re-organized the 2fa settings page to look like the rest of TeamPass, w stylesheet and nice XHTML.
(New English will make it even better)
Was:
Now:
Really difficult period for me currently with my internet line that is not good enough.