Update export.queries.php #1840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the "download" attribute. This attribute allows to download the file referenced in the "href" attribute when clicking on the link. In my opinion, as it was, the process of obtaining a file that could be used offline was not transparent... For less tech savvy users, it could lead to some problems.
|
Thank you for the tip. |
nilsteampassnet
added a commit
that referenced
this pull request
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have TeamPass installed on a machine with an IP address equal to 255.255.255.255, the link referenced in the "href" attribute (generated when using the offline mode) points to "http://255.255.255.255/teampass/files/...".
For users with less technological knowledge, what will probably happen is that they'll open the link and write down the generated URL on a paper. In the future, when trying to use it without an internet connection, it won't work.
My suggestion is to add the "download" attribute to the HTML "a" tag created. This attribute allows to download the file referenced in the "href" attribute when clicking on the link. This way, it'll be more clear that a file was created and users need to store it on a USB pen, for example, in order to be able to use it in the future.