Dependency & array update in install checks #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed mysqli_fetch_all dependency checks (obsolete and probably falsely showstopping), fixing layout breaks due to misordered array in respect to check order
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of my original pull request #1943 after I had to do a rebase on a different branch:
mysqli_fetch_all still does not seem to be used anywhere throughout teampass. So, pull request #1406 is imho right about removing this dependency (just like the Official Requirements Page did, it isn't even listed there.
Unfortunately by only removing the specific LOC of the dependency check for this function the check-layout in the routine get's broken because the array is misordered in terms of layout-referencing. This means after removal (like in pull request #1406, which seems to be abandoned and isn't based on actual code in master) the results after the checkpoints partially belong to other lines (example: check for writable /install shows missing extension).
I removed the dependency check for mysqli_fetch_all and reorganized the install.js check-array to reflect the actual order in install.php. Should also be easier to edit or expand in the future this way.
Tested with systematic dependency breaking and checking the results on install routine.