Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] builds.sr.ht: freebsd.yml does not restart when a PR is closed/re-opened #13553

Closed
timotheecour opened this issue Mar 1, 2020 · 2 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Mar 1, 2020

I've observed this a number of times; when a test is flaky and the PR is closed and re-opened to re-trigger CI, azure-pipelines tests are restarted (and so were travis and circle back in the days IIRC), but not builds.sr.ht: freebsd.yml (at least a lot of times it doesn't), so you end up with wasted CI cycles because the test still fails

Example

in #13546 (same problem with other recent PR's I've just restarted after the feb 29 bug, eg #13537)
image

Current Output

image

also, 1st few lines of https://builds.sr.ht/~araq/job/160965#task-test show the test wasn't restarted and was from yesterday:

[#160965] 2020/02/29 22:25:38 Booting image freebsd/latest (default) on port 22021
[#160965] 2020/02/29 22:25:41 Waiting for guest to settle
[#160965] 2020/02/29 22:26:02 Sending tasks

Expected Output

freebsd test restarts

workaround

do a dummy edit and force-push (not great)

@timotheecour timotheecour changed the title builds.sr.ht: freebsd.yml does not restart when a PR is closed/re-opened [CI] builds.sr.ht: freebsd.yml does not restart when a PR is closed/re-opened Mar 1, 2020
@Clyybber
Copy link
Contributor

Clyybber commented Mar 1, 2020

This is not something we can solve. You can open a ticket on sr.ht (dispatch.sr.ht handles github integration). But from their docs this is expected, as builds gets triggered on a push to a branch.

@Clyybber Clyybber closed this as completed Mar 1, 2020
@timotheecour
Copy link
Member Author

timotheecour commented Mar 1, 2020

I've asked here https://todo.sr.ht/~sircmpwn/dispatch.sr.ht/21#comment-6963 and currently the only workaround is to create an account (https://meta.sr.ht/) after which a "resubmit build" button is shown in https://builds.sr.ht/~araq/job/160965 ; it does work indeed

sadly, the feature request itself (as already supported by azure-pipelines etc) doesn't seem to be on their radar currently

I don't know. I've never found it a priority to fix someone else's bugs. Your test suite needs work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants