Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile-time symbol for genericsOpenSym #23385

Open
arnetheduck opened this issue Mar 10, 2024 · 1 comment · May be fixed by #23572
Open

Add compile-time symbol for genericsOpenSym #23385

arnetheduck opened this issue Mar 10, 2024 · 1 comment · May be fixed by #23572
Labels
Feature Generics Status

Comments

@arnetheduck
Copy link
Contributor

Summary

Add a nimGenericsOpenSym injected define when genericsOpenSym is enabled

Description

This is needed to write code that reacts to the experimental feature being enabled, in when expressions so that it can use workarounds when the feature is not enabled.

Alternatives

No response

Examples

No response

Backwards Compatibility

No response

Links

No response
@arnetheduck
Copy link
Contributor Author

Also add a nimHasGenericsOpenSym for nim versions that support the experimental - this allows libraries to detect when it's supported and not enabled (to prompt users to enable it)

@arnetheduck arnetheduck mentioned this issue Mar 11, 2024
Open
@Araq Araq added the Status label Mar 14, 2024
metagn added a commit to metagn/Nim that referenced this issue May 4, 2024
@metagn
fix genericsOpenSym switch by adding another node flag
db79610 
fixes nim-lang#23386, fixes nim-lang#23385
@metagn metagn linked a pull request May 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Generics Status
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix genericsOpenSym switch semantics by adding another node flag metagn/Nim
3 participants
@Araq @juancarlospaco @arnetheduck