Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File descripters should be non-inheritable by default. #6602

Closed
kvinwang opened this issue Oct 26, 2017 · 1 comment · Fixed by #13201
Closed

File descripters should be non-inheritable by default. #6602

kvinwang opened this issue Oct 26, 2017 · 1 comment · Fixed by #13201
Labels
Feature Standard Library

Comments

@kvinwang
Copy link
Contributor

kvinwang commented Oct 26, 2017 •
edited

I have encountered a problem when i am making a "process supervisor".
When the supervisor quit, each child process keep running and keep the fds interited from supervisor opening. The fds are leaked. Especially, there is no way to manually set the underlying fd of asynchttpserver as FD_CLOEXEC.

I think the file descripters should be non-inheritable by default.
Python from 3.4 (and many other languages) make file descripters non-inheritable by default.
See: https://www.python.org/dev/peps/pep-0446/

My original issue is here: dom96/jester#125
@zielmicha
Copy link
Contributor

This may be hard to accomplish, because system.nim uses fopen, which doesn't have portable CLOEXEC support (there is "e" mode, but it's only available in glibc)

@Araq Araq added the Feature label May 22, 2019
alaviss added a commit to alaviss/Nim that referenced this issue Jan 20, 2020
@alaviss
io: make file descriptors non-inheritable by default
c001d1c 
This prevents file descriptors/handles leakage to child processes
that might cause issues like running out of file descriptors, or potential
security issues like leaking a file descriptor to a restricted file.

While this breaks backward compatibility, I'm rather certain that not
many programs (if any) actually make use of this implementation detail.
A new API `setInheritable` is provided for the few that actually want to
use this functionality.

Ref nim-lang#6602
@alaviss alaviss mentioned this issue Jan 20, 2020
Merged
alaviss added a commit to alaviss/Nim that referenced this issue Jan 20, 2020
@alaviss
io: make file descriptors non-inheritable by default
e72420e 
This prevents file descriptors/handles leakage to child processes
that might cause issues like running out of file descriptors, or potential
security issues like leaking a file descriptor to a restricted file.

While this breaks backward compatibility, I'm rather certain that not
many programs (if any) actually make use of this implementation detail.
A new API `setInheritable` is provided for the few that actually want to
use this functionality.

Ref nim-lang#6602
alaviss added a commit to alaviss/Nim that referenced this issue Jan 20, 2020
@alaviss
io: make file descriptors non-inheritable by default
cbf71e0 
This prevents file descriptors/handles leakage to child processes
that might cause issues like running out of file descriptors, or potential
security issues like leaking a file descriptor to a restricted file.

While this breaks backward compatibility, I'm rather certain that not
many programs (if any) actually make use of this implementation detail.
A new API `setInheritable` is provided for the few that actually want to
use this functionality.

Ref nim-lang#6602
alaviss added a commit to alaviss/Nim that referenced this issue Jan 20, 2020
@alaviss
io: make file descriptors non-inheritable by default
91aa08f 
This prevents file descriptors/handles leakage to child processes
that might cause issues like running out of file descriptors, or potential
security issues like leaking a file descriptor to a restricted file.

While this breaks backward compatibility, I'm rather certain that not
many programs (if any) actually make use of this implementation detail.
A new API `setInheritable` is provided for the few that actually want to
use this functionality.

Ref nim-lang#6602
alaviss added a commit to alaviss/Nim that referenced this issue Jan 20, 2020
@alaviss
io: make file descriptors non-inheritable by default
741130e 
This prevents file descriptors/handles leakage to child processes
that might cause issues like running out of file descriptors, or potential
security issues like leaking a file descriptor to a restricted file.

While this breaks backward compatibility, I'm rather certain that not
many programs (if any) actually make use of this implementation detail.
A new API `setInheritable` is provided for the few that actually want to
use this functionality.

Ref nim-lang#6602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Standard Library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make file descriptors from stdlib non-inheritable by default alaviss/Nim
4 participants
@Araq @zielmicha @andreaferretti @kvinwang