Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests\async\tasyncssl.nim no longer works on windows (appveyor) #9689

Closed
skilchen opened this issue Nov 12, 2018 · 3 comments
Closed

tests\async\tasyncssl.nim no longer works on windows (appveyor) #9689

skilchen opened this issue Nov 12, 2018 · 3 comments
Labels

Comments

@skilchen
Copy link
Contributor

The CI runs on appveyor systematically fail on tests\async\tasyncssl.nim

appveyor probably upgraded its openssl to Win64 OpenSSL v1.1.1

If you try to use the dlls (libcrypto-1_1-x64.dll and libssl-1_1-x64.dll) from https://slproweb.com/download/Win64OpenSSL_Light-1_1_1.exe you get the same error running the tests locally.

With the dlls from https://nim-lang.org/download/dlls.zip (libeay64.dll, ssleay64.dll) or from https://slproweb.com/download/Win64OpenSSL_Light-1_1_0i.exe (libcrypto-1_1-x64.dll, libssl-1_1-x64.dll) the tests\async\tasyncssl.nim passes.

@timotheecour
Copy link
Member

timotheecour commented Nov 13, 2018

indeed, it affects a number of PR's;

  • how come Nim shows Build Status as pasing?
    image

example failure

https://ci.appveyor.com/project/Araq/nim/builds/20275193

Test "tests/async\tasyncssl.nim" in category "async"
Failure: reExitcodesDiffer
Expected:
exitcode: 0
Gotten:
exitcode: 1
Output:
tasyncssl.nim(63)        tasyncssl
system.nim(3930)         failedAssertImpl
system.nim(3923)         raiseAssert
system.nim(2970)         sysFatal
Error: unhandled exception: C:\projects\nim\tests\async\tasyncssl.nim(63, 10) `msgCount == swarmSize * messagesToSend`  [AssertionError]

maybe related

This isn't a valid fix though. The problem lies somewhere else and this PR is just working around it by accident.

dom96 added a commit that referenced this issue Nov 13, 2018
@dom96
Copy link
Contributor

dom96 commented Nov 13, 2018

I committed a workaround.

This was referenced Nov 13, 2018
@Araq Araq removed the CI label Apr 3, 2019
@Araq
Copy link
Member

Araq commented May 13, 2019

Well, a disabled test is a disabled test and it works with newer DLLs. Disabled tests are bad but not bugs.

@Araq Araq closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants