nimsuggest: add an option to bind to a free port #10328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jan 16, 2019
nimsuggest/nimsuggest.nim
Outdated
| @@ -275,7 +279,7 @@ proc connectToNextFreePort(server: Socket, host: string): Port = | |||
| result = port | |||
|
|
|||
| type | |||
| ThreadParams = tuple[port: Port; address: string] | |||
| ThreadParams = tuple[port: Port; address: string; findPort: bool] | |||
There was a problem hiding this comment.
If you use a global already there is no point in passing it to the thread explicitly.
alaviss
force-pushed
the
suggest-autoport
branch
from
f2e30f5
to
bb55717
Compare
|
@Araq done, also simplified the implementation a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows editor plugin writers to avoid rapidly launching nimsuggest until they hit a free port.