Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic analysis with noReturn proc in tail pos #10422

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

LemonBoy
Copy link
Contributor

Fixes #10417

@Araq Araq added the merge_when_passes_CI mergeable once green label Jan 22, 2019
@GULPF
Copy link
Member

GULPF commented Jan 22, 2019

This doesn't work when the try branch is the noReturn branch. Example:

let f =
  try:
    raiseAssert("Failure")
  except:
    1

Not sure if it matters, I cannot imagine a case where it would be useful to end a try branch with noReturn.

@Araq
Copy link
Member

Araq commented Jan 22, 2019

Not sure if it matters, I cannot imagine a case where it would be useful to end a try branch with noReturn.

Exactly.

@narimiran narimiran merged commit eee9729 into nim-lang:devel Jan 23, 2019
ThomasTJdev pushed a commit to ThomasTJdev/Nim that referenced this pull request Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants