Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./koch tests now does not rebuild nim #10572

Closed

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 6, 2019

note to reviewer:
i also changed:

echo "Version check: failure"

to use a doAssert, as echo didn't seem to make sense

@Araq
Copy link
Member

Araq commented Feb 8, 2019

Merged it manually.

@Araq Araq closed this Feb 8, 2019
@timotheecour
Copy link
Member Author

timotheecour commented Feb 8, 2019

@Araq maybe I'm missing something obvious but c7c495f only sets var compilerPrefix* = "nim" ; I don't understand why you want to keep this in koch tests:

# Since tests take a long time (on my machine), and we want to defy Murhpys law - lets make sure the compiler really is freshly compiled!
nimexec "c --lib:lib -d:release --opt:speed compiler/nim.nim" # => which builds compiler/nim.exe

IIUC, the only place compiler/nim.exe was being used after this call was var compilerPrefix* = "compiler" / "nim" , which is why i had removed it from this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants