fix echoBinSafe failure from #10559 #10576
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/ccgbugs/twrongrefcounting.nim
which uses-d:useGcAssert
indeed,
gcAssert
callsecho
, which causeserror: system module needs: echoBinSafe
Regardless of whether
gcAssert
should callecho
orwrite(cstdout, ...)
, the problem is that we weren't able to useecho
(ordebugEcho
) anywhere until afterimport io
is called.Not having access to
echo
makes it very inconvenient when we need to debug something inside system.nim (or itsincludes
)This PR fixes that.