Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix echoBinSafe failure from #10559 #10576

Closed
wants to merge 5 commits into from

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 6, 2019

indeed, gcAssert calls echo, which causes error: system module needs: echoBinSafe

Regardless of whether gcAssert should call echo or write(cstdout, ...), the problem is that we weren't able to use echo (or debugEcho) anywhere until after import io is called.

Not having access to echo makes it very inconvenient when we need to debug something inside system.nim (or its includes)

This PR fixes that.

@Araq
Copy link
Member

Araq commented Feb 6, 2019

Fixed it differently.

@Araq Araq closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants