Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the restriction that module names need to be unique per Nimble… #11064

Merged
merged 3 commits into from Apr 20, 2019

Conversation

Araq
Copy link
Member

@Araq Araq commented Apr 19, 2019

… package

@Araq Araq merged commit 0121dda into devel Apr 20, 2019
@Araq Araq deleted the araq-fake-package-names branch April 20, 2019 13:19
@kaushalmodi
Copy link
Contributor

@Araq: Can you please document in the manual and changelog as to what this change implies.

After this commit, I am seeing stuff like:

CC: stdlib_system
CC: stdlib_times
CC: stdlib_os
CC: _7_7_7_7_7_7_7_7home7kmodi7.nimble7pkgs7nimterop-#head7nimterop7plugin
CC: _7_7_7_7_7_7_7_7home7kmodi7.nimble7pkgs7nimterop-#head7nimterop7cimport

Before this commit, it looked like:

CC: stdlib_system
CC: stdlib_times
CC: stdlib_os
CC: nimterop_plugin
CC: nimterop_cimport

Ref: https://irclogs.nim-lang.org/21-04-2019.html#13:03:10

/cc @genotrance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants