New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --clearNimblePath; fixes #12601 #12609
Conversation
@@ -102,6 +102,7 @@ Advanced options: | |||
--putenv:key=value set an environment variable | |||
--NimblePath:PATH add a path for Nimble support | |||
--noNimblePath deactivate the Nimble path | |||
--clearNimblePath empty the list of Nimble package search paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--clearNimblePath empty the list of Nimble package search paths | |
--clearNimblePath empty the list of Nimble package search paths; more Nimble paths can be added after clearing using --NimblePath:PATH |
@@ -546,6 +546,9 @@ proc disableNimblePath*(conf: ConfigRef) = | |||
incl conf.globalOptions, optNoNimblePath | |||
conf.lazyPaths.setLen(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the order of disableNimblePath
and clearNimblePath
be switched and have disableNimblePath
call the other to do that setLen(0)
?
How do we write tests for these combinations:
|
I've not reviewed this change but am not a fan in principal since we have a goal of reducing Nim's awareness of Nimble in nim-lang/nimble#654. This adds even more behavior into Nim which will be harder to reduce or eliminate in a backwards compatible way. |
@genotrance true but in the meantime people need a solution. However, the same behaviour could be added to the existing |
This was discussed and |
(cherry picked from commit 738c957)
Per title; resets the list of Nimble search paths so that they may subsequently be manipulated by further
nimblePath
options.