exporting normalizePathEnd

[disruptek]

I dunno if this is the best way to conditionally export this proc in 1.1.

[timotheecour]

I dunno if this is the best way to conditionally export this proc in 1.1.

seems like the best way to me

[disruptek]

What do you think about renaming the copy version to normalizedPathEnd?

[timotheecour]

my 2 cents: I know there's a precedent for that (eg: sort vs sorted) but:

• it's not universally followed
• nim doesn't auto-discard (best language decision never) so there's no ambiguity in general (except some corner cases) in using same name for both versions
• outparam(outparam: allows to call in-place a proc with var result ; fixes #RFCs/issues/62 #11916) or sugar.outplace would also use same name

but ok with whatever you decide :)

[disruptek]

Divergent symbols are easier to recognize in IDE completion and easier to control in import statements, but if no one wants to rename it, I'm fine with it as is.

[Araq]

The problem with this PR is that technically speaking you're relying on a compiler bug to achieve this. export is for exporting symbols from an imported module.

[timotheecour]

The problem with this PR is that technically speaking you're relying on a compiler bug to achieve this. export is for exporting symbols from an imported module.

the "compiler bug" is IMO the more useful, consistent, less surprising behavior (and I've written code relying on that); we can just update the spec accordingly. The use-case in this PR is a good example; if we followed current spec, it'd lead to less DRY code.

[disruptek]

Hence my first comment. How would you like to do it?

[Araq]

the "compiler bug" is IMO the more useful, consistent, less surprising behavior (and I've written code relying on that); we can just update the spec accordingly.

Agreed, however it then needs to have tests of its own to ensure we don't break this feature. And this also includes little things like "nim doc needs to list every exported proc..."

[timotheecour]

And this also includes little things like "nim doc needs to list every exported proc..."

proc main()=discard
export main

just checked, nim doc indeed needs to be fixed to list main as public symbol instead of adding main in exports section. hopefully not hard

[timotheecour]

i really don't like code duplication and we don't need runnableExamples + unittest for this un-exported version, all this is already in normalizePathEnd*

[timotheecour]

let's wait until #13123 is merged, then the simple:

when (NimMajor, NimMinor) >= (1, 1):
  export normalizePathEnd

would work, avoiding all the above issues

[timotheecour]

@disruptek #13123 got merged so you can now rebase against latest devel and use the simple

when (NimMajor, NimMinor) >= (1, 1):
  export normalizePathEnd

[Araq]

@timotheecour It still needs to be documented.

[timotheecour]

@timotheecour It still needs to be documented.

this is what I mean: #13152 ; it shows documentation correctly and is simpler than this PR (and DRY)

[disruptek]

Nice.